Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DropdownMenu] add helperText & errorText to DropdownMenu Widget #123775

Merged
merged 10 commits into from Apr 6, 2023
Merged

[DropdownMenu] add helperText & errorText to DropdownMenu Widget #123775

merged 10 commits into from Apr 6, 2023

Conversation

piedcipher
Copy link
Member

@piedcipher piedcipher commented Mar 30, 2023 •
edited

Adds 2 new properties helperText & errorText to DropdownMenu.

Fixes: #119743

helperText Dropdown Closed errorText Dropdown Closed
photo_2023-03-30_20-21-07 photo_2023-03-30_20-21-06
helperText Dropdown Open errorText Dropdown Open
photo_2023-03-30_20-21-04 photo_2023-03-30_20-21-02

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 30, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@piedcipher piedcipher force-pushed the enhancement/dropdown-menu branch 11 times, most recently from 21ee04d to fefbbfe Compare March 31, 2023 20:20
@piedcipher piedcipher force-pushed the enhancement/dropdown-menu branch 5 times, most recently from 97713ae to 381d759 Compare April 3, 2023 16:48
QuncCccccc
QuncCccccc reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! Just left a few comments, but overall it looks great:)

packages/flutter/lib/src/material/dropdown_menu.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/dropdown_menu.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/dropdown_menu_test.dart Show resolved Hide resolved
@piedcipher
Copy link
Member Author

Thanks a lot for your contribution! Just left a few comments, but overall it looks great:)

Thanks a lot for the review! 💙🙌❤️ I've resolved all the comments.

QuncCccccc
QuncCccccc approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks:)

justinmc
justinmc approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for the thorough tests here.

packages/flutter/lib/src/material/dropdown_menu.dart Show resolved Hide resolved
@QuncCccccc
Copy link
Contributor

The Google testing is failing. I don't think the failure is related to the code change. We might need to rebase master and re-submit to trigger the test again:) Thanks!

@piedcipher
Copy link
Member Author

piedcipher commented Apr 5, 2023 •
edited

The Google testing is failing. I don't think the failure is related to the code change. We might need to rebase master and re-submit to trigger the test again:) Thanks!

Sure I'll rebase, but it failed for DanTup as well.

@piedcipher
Copy link
Member Author

piedcipher commented Apr 5, 2023 •
edited

The Google testing is failing. I don't think the failure is related to the code change. We might need to rebase master and re-submit to trigger the test again:) Thanks!

I did rebase, I don't know how these other commits got added :(

I used GitHub's UI (1 click) for rebase.

Edit: Fixed it. I think bug is on GitHub.

@piedcipher
Copy link
Member Author

auto label is removed for flutter/flutter, pr: 123775, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

This check is failing on all PRs at the moment.

@piedcipher
Copy link
Member Author

piedcipher commented Apr 6, 2023 •
edited

Can we please add auto-submit label again?

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@piedcipher
Copy link
Member Author

piedcipher commented Apr 6, 2023 •
edited

Thank you for adding the label. Number of checks are 8 now, earlier there were 71.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 6, 2023

auto label is removed for flutter/flutter, pr: 123775, Failed to merge pr#: 123775 with Pull request could not be merged: Required status check "ci.yaml validation" is expected..

@piedcipher
Copy link
Member Author

piedcipher commented Apr 6, 2023 •
edited

auto label is removed for flutter/flutter, pr: 123775, Failed to merge pr#: 123775 with Pull request could not be merged: Required status check "ci.yaml validation" is expected..

Can I please get auto-submit label again? Sorry to bother again. Previous failure was due to an infra issue #124332.

All green now 💚

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@justinmc
Copy link
Contributor

justinmc commented Apr 6, 2023

No worries. It looks like the Google tests are running now though.

@auto-submit auto-submit bot merged commit 6338ab1 into flutter:master Apr 6, 2023
72 checks passed
@piedcipher piedcipher deleted the enhancement/dropdown-menu branch April 6, 2023 21:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2023
@engine-flutter-autoroll
6338ab157 [DropdownMenu] add helperText & errorText to DropdownMenu W…
be96359 
…idget (flutter/flutter#123775)
@HansMuller HansMuller mentioned this pull request Apr 7, 2023
Open
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@piedcipher @exaby73
[DropdownMenu] add helperText & errorText to DropdownMenu Widget (flu…
c706470 
…tter#123775)

[DropdownMenu] add helperText & errorText to DropdownMenu Widget
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6338ab157 [DropdownMenu] add helperText & errorText to DropdownMenu W…
be6bd19 
…idget (flutter/flutter#123775)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6338ab157 [DropdownMenu] add helperText & errorText to DropdownMenu W…
13bfd9e 
…idget (flutter/flutter#123775)
@piedcipher piedcipher mentioned this pull request Nov 18, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing errorText and helperText parameters in M3 DropdownMenu
3 participants
@piedcipher @QuncCccccc @justinmc