Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand deprecation policy to package:flutter_test #122323

Closed
4 tasks done
Piinks opened this issue Mar 9, 2023 · 7 comments
Closed
4 tasks done

Expand deprecation policy to package:flutter_test #122323

Piinks opened this issue Mar 9, 2023 · 7 comments
Assignees
@Piinks
Labels
a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@Piinks
Copy link
Contributor

Piinks commented Mar 9, 2023 •
edited

This is the tracking issue for the proposal to expand the deprecation policy to package:flutter_test

When first introduced, we decided to first focus the application of the deprecation policy on just the flutter package. During that time we worked on the process and gathered feedback from users. This process has become pretty stable, and so we are looking to expand it to other packages, with the first being flutter_test.

This will involve:

If we were to do this after the next release (not the current round that completed with #119580 but the next round), these would be up for removal:

class / method property deprecated in
AnimationSheetBuilder display 2.3
AnimationSheetBuilder sheetSize 2.3
TestWidgetsFlutterBinding addTime 2.6
TestWidgetsFlutterBinding runAsync 2.6
TestWidgetsFlutterBinding.runTest timeout 2.6
AutomatedTestWidgetsFlutterBinding.runTest timeout 2.6
LiveTestWidgetsFlutterBinding.runTest timeout 2.6
testWidgets initialTimeout 2.6

cc @goderbauer @pdblasi-google
@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. labels Mar 9, 2023
@Piinks Piinks self-assigned this Mar 9, 2023
@gslender
Copy link
Contributor

gslender commented Mar 9, 2023 •
edited

Is this appropriate place to raise issues with depreciation of methods and classes (in the flutter_test package) that are still needed because no equivalent method or class exists?

@Piinks
Copy link
Contributor Author

Piinks commented Mar 9, 2023

Is this appropriate place to raise issues with depreciation of methods and classes that are still needed because no equivalent method or class exists?

Definitely! I think all of the listed APIs have migration paths, but if we are missing one we certainly would love to know!

@workerbee22
Copy link

workerbee22 commented Mar 9, 2023 •
edited

If we are extending to flutter_test would you consider also integration_test (now also part of the framework)? Then all core testing components covered 🤔 Because lets face it, Dart fixes for flutter_test would largely also appy to Dart code used within integration_test?

@Piinks
Copy link
Contributor Author

Piinks commented Mar 9, 2023 •
edited

If we are extending to flutter_test would you consider also integration_test (now also part of the framework)?

Great question! The long term goal is to expand the policy to cover all packages in flutter/flutter, and maybe even dart:ui. 🙂

We're just doing this at a considerate pace since it means more potential breaking changes for developers.

@pdblasi-google
Copy link
Contributor

@Piinks I added a link to a ticket for adding dart fix support to the description. I plan on starting on it in the next couple weeks, hopefully early next week.

@pdblasi-google pdblasi-google mentioned this issue Mar 31, 2023
Open
@pdblasi-google pdblasi-google mentioned this issue Apr 6, 2023
Merged
8 tasks
pdblasi-google added a commit to pdblasi-google/flutter that referenced this issue Apr 10, 2023
@pdblasi-google
Adds dart_fix support to flutter_test
3a8e18d 
* Adds fixes for the first round of deprecations listed in flutter#122323
* Adds tests for all new fixes
* Adds a note for the `runTest(timeout)` deprecations to prevent them from being removed before `integration_test` also has `dart fix` support
@Piinks
Copy link
Contributor Author

Piinks commented May 17, 2023

Closing this as we are about to proceed with the next batch of deprecations, including flutter_test. Follow along in #127042

@Piinks Piinks closed this as completed May 17, 2023
@Piinks Piinks mentioned this issue May 17, 2023
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Piinks Piinks

Labels
a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gslender @workerbee22 @Piinks @pdblasi-google