New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CupertinoRadio Widget #123296

Merged

auto-submit merged 10 commits into flutter:master from MitchellGoodwin:create-cupertino-radio

Mar 30, 2023

Contributor

MitchellGoodwin commented Mar 22, 2023 •

edited

Addresses #102813. Adds a radio widget to Cupertino. Like the checkbox, this will be made adaptable with the Material radio widget.

Here's the radio buttons in the macOS settings:

And here's the Cupertino version in action, including keyboard focus/ interaction:

Screen.Recording.2023-03-22.at.3.49.57.PM.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard bot added d: api docs d: examples documentation f: cupertino framework team labels

MitchellGoodwin marked this pull request as ready for review

March 24, 2023 17:31

MitchellGoodwin requested a review from gspencergoog

March 27, 2023 17:34

gspencergoog reviewed

View reviewed changes

Contributor

gspencergoog left a comment

Both of the examples will need tests. See some of the other tests under examples/api/test to see how they're written. They're pretty simple tests just to make sure that the example displays the expected components of the example.

examples/api/lib/cupertino/radio/radio.0.dart Outdated

    
              class MyApp extends StatelessWidget {

                const MyApp({super.key});

                static const String _title = 'Flutter Code Sample';

Contributor

gspencergoog Mar 27, 2023

You should give this a more specific name: (e.g. 'CuptertinoRadio Example').

examples/api/lib/cupertino/radio/radio.0.dart Outdated

    
              void main() => runApp(const MyApp());

              class MyApp extends StatelessWidget {

Contributor

gspencergoog Mar 27, 2023

Try naming the app something like "CupertinoRadioApp" or something to make it match the example.

examples/api/lib/cupertino/radio/radio.0.dart Outdated

    
              // Use of this source code is governed by a BSD-style license that can be

              // found in the LICENSE file.

              // Flutter code sample for [CupertinoRadio].

Contributor

gspencergoog Mar 27, 2023

Suggested change

      
            // Flutter code sample for [CupertinoRadio].
          
            /// Flutter code sample for [CupertinoRadio].

This should be a doc comment so that IDE users can click on the link to get back to the class the example is attached to.

You might need to move this below the import if the analyzer complains.

examples/api/lib/cupertino/radio/radio.0.dart Outdated

    
                @override

                Widget build(BuildContext context) {

                  return const CupertinoApp(

                    title: _title,

Contributor

gspencergoog Mar 27, 2023

You can probably get rid of this. The title is not really used on iOS, I don't think. On Android it's used when you pull down the window shade, but that's all.

examples/api/lib/cupertino/radio/radio.0.dart Outdated

    
              enum SingingCharacter { lafayette, jefferson }

              class MyStatefulWidget extends StatefulWidget {

Contributor

gspencergoog Mar 27, 2023

Name this something specific to this example: CupertinoRadioExample or something.

packages/flutter/lib/src/cupertino/radio.dart Outdated

    
                ///

                /// The radio button passes [value] as a parameter to this callback. The radio

                /// button does not actually change state until the parent widget rebuilds the

                /// radio button with the new [groupValue].

Contributor

gspencergoog Mar 27, 2023

Suggested change

      
              /// radio button with the new [groupValue].
          
              /// radio button with a new [groupValue].

packages/flutter/lib/src/cupertino/radio.dart Show resolved Hide resolved

packages/flutter/lib/src/cupertino/radio.dart Outdated

    
                /// This example shows how to enable deselecting a radio button by setting the

                /// [toggleable] attribute.

                ///

                /// ** See code in examples/api/lib/cupertino/radio/radio.toggleable.0.dart **

Contributor

gspencergoog Mar 27, 2023

Suggested change

      
              /// ** See code in examples/api/lib/cupertino/radio/radio.toggleable.0.dart **
          
              /// ** See code in examples/api/lib/cupertino/radio/cupertino_radio.toggleable.0.dart **

packages/flutter/lib/src/cupertino/radio.dart Outdated

    
                /// Defaults to [CupertinoColors.white].

                final Color? fillColor;

                /// The color for the radio's border shadow when it has the input focus.

Contributor

gspencergoog Mar 27, 2023

Is it really a "shadow"? I think I'd call it just a border.

packages/flutter/lib/src/cupertino/radio.dart Outdated

    
                @override

                Widget build(BuildContext context) {

                  const Size size = Size(18.0, 18.0);

Contributor

gspencergoog Mar 27, 2023

You might move this to a named constant at the top of the file.

MitchellGoodwin force-pushed the create-cupertino-radio branch from 29f8af3 to 783cf86 Compare

March 27, 2023 21:47

MitchellGoodwin added 10 commits

March 29, 2023 11:32


          Beginning of cupertino radio

2c7393a


          Continue radio

2d3fc5f


          Update radio painter

08cd78b


          Connect with focus events

297f485


          Add tests

5cced8a


          Add examples

b77ccc2


          Update documentation

86bf704


          Fix example

fea9083


          Refactor test

e27a5af


          Add tests to examples and update docs

815fbe3

MitchellGoodwin force-pushed the create-cupertino-radio branch from 783cf86 to 815fbe3 Compare

March 29, 2023 18:32

gspencergoog approved these changes

View reviewed changes

Contributor

gspencergoog left a comment

MitchellGoodwin added the autosubmit label

auto-submit bot merged commit 84078c8 into flutter:master

72 checks passed

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to 302c087738a4 (46 revisions) flutter/packages#3593

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

29e6d6b

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to 8c5d223bab70 (49 revisions) flutter/packages#3594

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

76bfab7

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to 5f7117948072 (50 revisions) flutter/packages#3595

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

428323e

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to a28aae918eae (51 revisions) flutter/packages#3597

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

02aaa39

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to d940f60b4680 (70 revisions) flutter/packages#3605

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

b338176

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to f6c2b10e1a98 (71 revisions) flutter/packages#3606

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

c34692b

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to f5415a42d342 (72 revisions) flutter/packages#3607

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

0d5d210

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to 63e30480cd51 (74 revisions) flutter/packages#3608

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

e7f6491

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to 9a344c2604ec (75 revisions) flutter/packages#3609

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

62d3ea4

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to a8117bf18778 (76 revisions) flutter/packages#3610

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 12b36de8f7ac to 9d820aa35a22 (77 revisions) flutter/packages#3611

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

ea09f1d

HansMuller mentioned this pull request

Flutter Framework Team: Notable Commits #121415

Open

reidbaker mentioned this pull request

Add Java-Gradle-AGP validation to flutter analyze #123916

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

fada723

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

cbb9aea

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

02b9d41

reidbaker mentioned this pull request

Update getGradleVersion to ignore commented out lines #124260

Merged

8 tasks

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request


          Create CupertinoRadio Widget (flutter#123296)

e49b61b

Create CupertinoRadio Widget

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

297550c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          84078c856 Create CupertinoRadio Widget (flutter/flutter#123296)

a1833db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment