New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content-based colorScheme functionality #122919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: examples
Sample code and demos
documentation
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
team
Infra upgrades, team productivity, code health, technical debt. See also team: labels.
labels
Mar 17, 2023
esouthren
added a commit
to flutter/assets-for-api-docs
that referenced
this pull request
Mar 17, 2023
For flutter/flutter#122919. Images are used in the demo for image color extraction to generate color schemes. Images are owned by Google and have unrestricted licensing.
esouthren
added a commit
to flutter/assets-for-api-docs
that referenced
this pull request
Mar 17, 2023
For flutter/flutter#122919. Images are used in the demo for image color extraction to generate color schemes. Images are owned by Google and have unrestricted licensing.
HansMuller
approved these changes
Mar 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Nearly all of the feedback is trivial formatting stuff (mostly just advocating fewer line breaks).
5 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
d: api docs
Issues with https://api.flutter.dev/
d: examples
Sample code and demos
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
team
Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119333.
Adds
ColorScheme.fromImageProvider()
constructor to Material's color scheme.This allows users to pass an
ImageProvider
and receive a Material-based color scheme from the dominant colors of the image. By using anImageProvider
, developers can use local assets, network or memory images. We use the Material Color Utilities library to extract and score the dominant colors of the image.The scheme can be in light or dark mode, and additionally, any property of the scheme can be overridden with custom colors if they are preferred over the generated colors.
An
examples/
demo has been added, with a further update to the Material 3 demo app to come.The example demo looks as follows:
screen.mov
Pre-launch Checklist
///
).