Support iOS wireless debugging #118104

vashworth · 2023-01-06T17:27:43Z

Allows you to run flutter with a wireless iOS device. Uses mDNS service to get the IP of the wireless device and then access the observatory using it.

Unlike when running through a usb device, the Dart VM port does not get forwarded. --device-vmservice-port and --dds-port works same as before. --host-vmservice-port is slightly different. Before it would use host-vmservice-port as the port to forward the Dart VM to if dds-port was also provided, but if dds-port was not provided, it would use host-vmservice-port as the port for the DDS service and select a random port for the forwarded Dart VM. With this change host-vmservice-port is not used for port forwarding since there is none. It will only be used as the port for the DDS service if dds-port is not provided, but if dds-port is provided host-vmservice-port is basically ignored.

I tested flutter run, flutter attach, flutter install, and flutter screenshot, flutter drive.

Fixes #15072.

Steps to setup

Attach a iOS device to your Mac.
Make sure device is on same wifi as Mac.
Make sure the device has a passcode set.
Open Xcode > Window > Devices and Simulators > Choose your phone, then check Connect via Network

(If you don't get that little network icon next to the device name it probably didn't work, regardless of checkbox state.)
Unplug your device from USB.

Steps to test `flutter run`

Complete setup
flutter run --device-timeout 5

Steps to test `flutter attach` (with app running in Xcode)

Complete setup
Open Xcode > Product > Scheme > Edit Scheme
Click the Arguments tab at the top and then add --observatory-host=0.0.0.0 (IPv4) or --observatory-host=::0 (IPv6) as launch argument
Run through Xcode
flutter attach --device-timeout 5

Steps to test with IPv6

To test any of the above commands with IPv6, you need to use the --ipv6 flag when running the commands. You'll need to setup an IPv6 network. I used this tutorial to temporarily create an IPv6 network:
https://developer.apple.com/library/archive/documentation/NetworkingInternetWeb/Conceptual/NetworkingOverview/UnderstandingandPreparingfortheIPv6Transition/UnderstandingandPreparingfortheIPv6Transition.html#//apple_ref/doc/uid/TP40010220-CH213-SW16

Limitations

~~Must run once connected and click "Allow" to network permission prompt.~~ Fixed by 7b6da55.
Manually need to setup iPhone with Xcode to be connected via network.
Must be on same wifi (from what I can tell this is needed if running through Xcode too, so probably an acceptable limitation)
It takes longer to find network devices and get their info. Currently if it takes longer than 2 seconds to find it, it will skip it and not show as a selectable option. To workaround this, you can use --device-timeout flag to set the timeout longer.
For flutter attach to work (when running app in Xcode), user must manually add launch argument to Xcode.
Cannot use --no-publish-port flag. mDNS is required for this to work.

Things still need to be done

This will still work even without these fixes, but these fixes will help stabilize it.

iOS network device not available when doing flutter run #118109
- Workaround: add flag --device-timeout 5
Xcode build sometimes runs 'Thin Binary' script before 'Process Info.plist' which causes mDNS errors. #118058
- Workaround: If repeatedly getting mDNS error, try flutter clean.

iOS network device not selected when running/debugging in VSCode #118113

Workaround: VSCode > Run > Add/Open Configuration, add --device-timeout 5 as arg to default configuration (see below)

{
  ...
  "configurations": [
      {
          "name": "my_app",
          "request": "launch",
          "type": "dart",
          "args": ["--device-timeout", "5"]
      },
      ...
  ]
}

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

vashworth · 2023-01-06T17:38:32Z

packages/flutter_tools/lib/src/ios/devices.dart

@@ -413,11 +413,32 @@ class IOSDevice extends Device {
      }

      _logger.printTrace('Application launched on the device. Waiting for observatory url.');
-      final Timer timer = Timer(discoveryTimeout ?? const Duration(seconds: 30), () {
-        _logger.printError('iOS Observatory not discovered after 30 seconds. This is taking much longer than expected...');
+      final int defaultTimeout = interfaceType == IOSDeviceConnectionInterface.network ? 60 : 30;


I found that this took longer when using a network device. 60 seconds might be a bit generous, though. Sometimes 30 seconds is enough, but sometimes it's more like 35. Not sure if people's internet connections might influence this (mine is pretty fast), which is why I overestimated.

Wow that's a long time. Maybe 45 and we'll see if we get complaints?

Sounds good. Updated.

vashworth · 2023-01-06T19:57:13Z

@jmagman As we discussed before, this solution does not require any engine changes. However, the biggest drawback to this approach in my opinion is that you need to run in once while connected and click "Allow" for the network permission prompt. We could extend the timeout and print something in the command line to let them know they need to accept it, but I'm unsure of how to confirm that they did without some output from the engine to tell the tool. Let me know if you have any ideas.

vashworth · 2023-01-06T20:16:53Z

packages/flutter_tools/lib/src/macos/xcdevice.dart

+      loadDevicesStatus = _logger.startProgress(
+        'Loading devices...',
+      );
+    }


This change just gives some visual feedback that it's loading the devices.

jmagman · 2023-01-06T21:07:24Z

However, the biggest drawback to this approach in my opinion is that you need to run in once while connected and click "Allow" for the network permission prompt. We could extend the timeout and print something in the command line to let them know they need to accept it, but I'm unsure of how to confirm that they did without some output from the engine to tell the tool. Let me know if you have any ideas.

Which timeout is this hitting? Can we get rid of the timeout if we know we're on wireless? Generally in the tool we like to avoid hard timeouts and instead prefer "this is taking longer than expected..." type output.

jmagman · 2023-01-06T21:17:55Z

packages/flutter_tools/lib/src/ios/devices.dart

+      _logger.printError('Port publication (publish-port) must be enabled for wireless debugging.');
+      return LaunchResult.failed();


Messages like this need to be actionable by the user. What are they supposed to do in this case to fix it? When we have actionable errors like this we should throwToolExit.

Something like:

Suggested change

_logger.printError('Port publication (publish-port) must be enabled for wireless debugging.');

return LaunchResult.failed();

throwToolExit('Cannot start app on wirelessly tethered iOS device. Try running again with the --publish-port flag');

Introduced in #67452 to prevent the pop-up from blocking the app in a CI setting.

Maybe drive should default to always publishing, and we update our CI scripts to pass --no-publish-port so users manually running tests won't hit this? wdyt?

Updated the error message.

And thanks for the reminder about drive, I misunderstood the first time we talked about it. I tried a different approach, so basically added an override for disablePortPublication that checks if the flag wasn't provided as an actual argument and it's a network device, then changes publish-port to be enabled. It's a little bit hacky, but allows drive to continue functioning as it was before for all wired devices without needing to update anything. Let me know if you think that's not a good solution.

jmagman · 2023-01-06T21:19:09Z

packages/flutter_tools/lib/src/ios/devices.dart

@@ -413,11 +413,32 @@ class IOSDevice extends Device {
      }

      _logger.printTrace('Application launched on the device. Waiting for observatory url.');
-      final Timer timer = Timer(discoveryTimeout ?? const Duration(seconds: 30), () {
-        _logger.printError('iOS Observatory not discovered after 30 seconds. This is taking much longer than expected...');
+      final int defaultTimeout = interfaceType == IOSDeviceConnectionInterface.network ? 60 : 30;


Wow that's a long time. Maybe 45 and we'll see if we get complaints?

packages/flutter_tools/lib/src/mdns_discovery.dart

vashworth · 2023-01-06T21:32:21Z

Which timeout is this hitting? Can we get rid of the timeout if we know we're on wireless? Generally in the tool we like to avoid hard timeouts and instead prefer "this is taking longer than expected..." type output.

This lookup has a default timeout of 5 seconds

flutter/packages/flutter_tools/lib/src/mdns_discovery.dart

Lines 69 to 73 in b63c79c

    
           final List<PtrResourceRecord> pointerRecords = await _client 
        
             .lookup<PtrResourceRecord>( 
        
               ResourceRecordQuery.serverPointer(dartObservatoryName), 
        
             ) 
        
             .toList();

In the comments of the lookup function, it describe the timeout as "The [timeout] parameter specifies how long the internal cache should hold on to the record.". However, from what I can tell in the code and having observed by testing it out, seems to me that timeout is how long it continues to look for records.
https://github.com/flutter/packages/blob/e1ab965985d4e8ab5fdcf1b9989cf1c22d770205/packages/multicast_dns/lib/multicast_dns.dart#L189-L228
https://github.com/flutter/packages/blob/e1ab965985d4e8ab5fdcf1b9989cf1c22d770205/packages/multicast_dns/lib/src/lookup_resolver.dart#L42-L45

So to remove the timeout, we'd have to update the multicast_dns package, which we could do. ~~We could also just make it a really long timeout perhaps? And have a secondary timeout that warns them it's taking longer than expected?~~ Just remembered it doesn't stop when it finds it.

jmagman · 2023-01-06T21:34:11Z

This lookup has a default timeout of 5 seconds

Can we keep retrying the lookup on the tool side when it times out?

vashworth · 2023-01-06T21:50:22Z

This lookup has a default timeout of 5 seconds

Can we keep retrying the lookup on the tool side when it times out?

That's a good idea, I'll try that

…takes too long to find observatory url, update flutter drive to enable publish-port if using network device

jmagman

This is looking great!

packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart

packages/flutter_tools/lib/src/commands/drive.dart

jmagman · 2023-01-09T23:15:22Z

packages/flutter_tools/lib/src/ios/devices.dart

+        // Wait for iOS Observatory to start up.
+        await observatoryDiscovery?.uri;
+
+        // If observatory url is not found within 2.2 seconds, change the status


This caller shouldn't have to know the guts of MDnsObservatoryDiscovery to know it's a 2 second timeout. Instead, try adding the lookup duration parameter into MDnsObservatoryDiscovery, and then add 200 ms to it out here.

packages/flutter_tools/lib/src/mdns_discovery.dart

jmagman · 2023-01-09T23:19:28Z

packages/flutter_tools/lib/src/mdns_discovery.dart

+
+      List<PtrResourceRecord> pointerRecords = <PtrResourceRecord>[];
+      if (isNetworkDevice) {
+        // Keep checking for records every 2 seconds.


It looks like this restarts the lookup every 2 seconds. Can we instead let it look for longer, since the caller will handle "this is taking longer than expected"?

https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#never-check-if-a-port-is-available-before-using-it-never-add-timeouts-and-other-race-conditions

(I realize this contradicts the advice of #118104 (comment) but it seems like we can let the internal lookup take much longer until it finds the record, and the external caller to handle the "well this is taking awhile, make sure you hit Allow")

How long did you have in mind? The default was 5 seconds, but when I tested it, 2 seconds was always enough time but maybe that's an invalid assumption. And this lookup does not end when it finds it, it will end at the timeout. So if you put a timeout of 30 seconds, it will run for 30 seconds regardless of what it finds. So if we put a higher timeout, that's longer that the user has to wait for it to finish even though it probably already found what it's looking for.

And this lookup does not end when it finds it, it will end at the timeout.

It looks like it's returning a Stream, are you sure it's not waiting that long because you added a toList() at the end, which will wait until the stream is closed?
https://github.com/flutter/packages/blob/e1ab965985d4e8ab5fdcf1b9989cf1c22d770205/packages/multicast_dns/lib/src/lookup_resolver.dart#L48

See their await for example:
https://github.com/flutter/packages/blob/88585ef98897007eacc1895f90e1288b5624b960/packages/multicast_dns/example/main.dart#L21-L22

You're right, I see. I refactored so it stays open for longer (10 minutes). Let me know if you think longer/shorter time would be better

…ultiple instances of the same app. Update drive command to make publish-port more stable. Update attach for iOS to only use Protocol Discovery if applicable, run mDNS and Protocol Discovery simultaneously, handle --debug-port/--debug-url/--device-vmservice-port, continously poll for obseravtories with mDNS, include port in error message when mutliple available

packages/flutter_tools/lib/src/commands/attach.dart

packages/flutter_tools/lib/src/mdns_discovery.dart

packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart

packages/flutter_tools/lib/src/mdns_discovery.dart

jmagman · 2023-01-12T20:22:11Z

packages/flutter_tools/lib/src/mdns_discovery.dart

+    Duration timeout = const Duration(minutes: 10),
+  }) async {
+    // Poll for 5 seconds to see if there are already services running.
+    // Use a new instance of MDnsClient so result don't get cached in _client.


Why don't we want to cache the results? Will the presence of anything in the cache cause it to not to try and lookup anything again?

Exactly, so if it finds records in the first 5 second poll but it doesn't match the parameters (app id and/or device port), those results are cached and then the next poll will end immediately because it gets from the cache.

https://github.com/flutter/packages/blob/62e04e1267c7f10cc00e6a4334213656b46d3964/packages/multicast_dns/lib/multicast_dns.dart#L208-L216

…r attach, other small improvements

…le print the time it took.

* Reland "Support iOS wireless debugging (#118104)" This reverts commit cbf2e16. * Remove device loading status

@pragma

* 3348987 Add new macos target configured for flavors (flutter/flutter#117352) * 6277520 Roll Plugins from 4e5cf2d to 11361d0 (4 revisions) (flutter/flutter#118682) * 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a Fix path for require.js (flutter/flutter#118722) * c83a698 update uikit view documentation (flutter/flutter#118715) * 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e Docs fix an=>a (flutter/flutter#118652) * 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681) * 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104) * cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421) * 030288d Revert "[macos] add flavor options to commands in the `flutter_tool` (#118421)" (flutter/flutter#118858) * 9acf34d Roll Flutter Engine from 26b6609c603b to 7d40e77d0035 (2 revisions) (flutter/flutter#118852) * ec51d32 Remove unnecessary null checks in ‘dev/conductor’ (flutter/flutter#118843) * 54217bd Remove unnecessary null checks in `dev/benchmarks` (flutter/flutter#118840) * 98c18ca Remove unnecessary null checks in examples/ (flutter/flutter#118848) * 99b5262 Remove unnecessary null checks in dev/tools (flutter/flutter#118845) * 52d1205 Roll Flutter Engine from 7d40e77d0035 to 730e88fb6787 (3 revisions) (flutter/flutter#118869) * ee9c9b6 3876320cb Roll Skia from aedfc8695954 to 1b3aa8b6e1cc (43 revisions) (flutter/engine#39024) (flutter/flutter#118871) * 589f2eb d2436a536 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39020) (flutter/flutter#118873) * 74645b4 Fix `NavigationBar` indicator ripple doesn't account for label height (flutter/flutter#117473) * f78b1f3 dfe67f4c7 Roll Skia from 1b3aa8b6e1cc to f6a5c806294d (11 revisions) (flutter/engine#39027) (flutter/flutter#118874) * 572f0a1 66e177a3d Roll Dart SDK from ddf70a598f27 to fbbfc122dba6 (9 revisions) (flutter/engine#39029) (flutter/flutter#118878) * 26472b5 ccccee513 [macos] Synthesize modifier keys events on pointer events (flutter/engine#37870) (flutter/flutter#118880) * 095b1ab Checkbox borderSide lerp bug fix (flutter/flutter#118728) * ec6ff90 Roll Flutter Engine from ccccee513fb2 to d84b3dc74c9f (2 revisions) (flutter/flutter#118893) * 492d572 Cleanup obsolete --compact-async compiler option (flutter/flutter#118894) * f291eb3 Remove unnecessary null checks in integration_test (flutter/flutter#118861) * ab3c822 Remove unnecessary null checks in dev/devicelab (flutter/flutter#118842) * bf72f5e 58eb1061e Revert "Remove references to Observatory (#38919)" (flutter/engine#39035) (flutter/flutter#118899) * a07e8a6 [reland] Support wireless debugging (flutter/flutter#118895)

@pragma

* 3348987 Add new macos target configured for flavors (flutter/flutter#117352) * 6277520 Roll Plugins from 4e5cf2d to 11361d0 (4 revisions) (flutter/flutter#118682) * 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a Fix path for require.js (flutter/flutter#118722) * c83a698 update uikit view documentation (flutter/flutter#118715) * 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e Docs fix an=>a (flutter/flutter#118652) * 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681) * 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104) * cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421) * 030288d Revert "[macos] add flavor options to commands in the `flutter_tool` (#118421)" (flutter/flutter#118858) * 9acf34d Roll Flutter Engine from 26b6609c603b to 7d40e77d0035 (2 revisions) (flutter/flutter#118852) * ec51d32 Remove unnecessary null checks in ‘dev/conductor’ (flutter/flutter#118843) * 54217bd Remove unnecessary null checks in `dev/benchmarks` (flutter/flutter#118840) * 98c18ca Remove unnecessary null checks in examples/ (flutter/flutter#118848) * 99b5262 Remove unnecessary null checks in dev/tools (flutter/flutter#118845) * 52d1205 Roll Flutter Engine from 7d40e77d0035 to 730e88fb6787 (3 revisions) (flutter/flutter#118869) * ee9c9b6 3876320cb Roll Skia from aedfc8695954 to 1b3aa8b6e1cc (43 revisions) (flutter/engine#39024) (flutter/flutter#118871) * 589f2eb d2436a536 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39020) (flutter/flutter#118873) * 74645b4 Fix `NavigationBar` indicator ripple doesn't account for label height (flutter/flutter#117473) * f78b1f3 dfe67f4c7 Roll Skia from 1b3aa8b6e1cc to f6a5c806294d (11 revisions) (flutter/engine#39027) (flutter/flutter#118874) * 572f0a1 66e177a3d Roll Dart SDK from ddf70a598f27 to fbbfc122dba6 (9 revisions) (flutter/engine#39029) (flutter/flutter#118878) * 26472b5 ccccee513 [macos] Synthesize modifier keys events on pointer events (flutter/engine#37870) (flutter/flutter#118880) * 095b1ab Checkbox borderSide lerp bug fix (flutter/flutter#118728) * ec6ff90 Roll Flutter Engine from ccccee513fb2 to d84b3dc74c9f (2 revisions) (flutter/flutter#118893) * 492d572 Cleanup obsolete --compact-async compiler option (flutter/flutter#118894) * f291eb3 Remove unnecessary null checks in integration_test (flutter/flutter#118861) * ab3c822 Remove unnecessary null checks in dev/devicelab (flutter/flutter#118842) * bf72f5e 58eb1061e Revert "Remove references to Observatory (#38919)" (flutter/engine#39035) (flutter/flutter#118899) * a07e8a6 [reland] Support wireless debugging (flutter/flutter#118895)

@pragma

…r#3073) * da5f8cf90 Roll Flutter Engine from a512cebdcd30 to 7dc5e7efa66a (2 revisions) (flutter/flutter#118505) * baefeccbe 35479aa1c Roll Fuchsia Mac SDK from 21nYb648VWbpxc36t... to w0hr1ZMvYGJnWInwK... (flutter/engine#38880) (flutter/flutter#118509) * ca300ce57 25cb82272 Add include to make g3 happy (flutter/engine#38850) (flutter/flutter#118510) * 1220245b3 f79030440 Roll Skia from c72c7bf7e45b to c64a10d525d1 (7 revisions) (flutter/engine#38858) (flutter/flutter#118511) * 7188c3e62 Update documentation about accent color (flutter/flutter#116778) * 8c2fdb803 M3 Button padding adjustments (flutter/flutter#118449) * f22280a0c Revert "M3 Button padding adjustments (#118449)" (flutter/flutter#118598) * cc7845e71 Post a ToolEvent when selecting widget for inspection (flutter/flutter#118098) * a3629a223 Roll Plugins from 92a5367 to 4e5cf2d (8 revisions) (flutter/flutter#118624) * ae7b99efb Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc33f Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9bbd Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030a9 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d551c Devicelab android emulator (flutter/flutter#113472) * 0eaa83ad6 Fix some Focus related documentation typos (flutter/flutter#118576) * 780563ce0 Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff40b [Re-land] Button padding m3 (flutter/flutter#118640) * 334898754 Add new macos target configured for flavors (flutter/flutter#117352) * 627752064 Roll Plugins from 4e5cf2d to 11361d0 (4 revisions) (flutter/flutter#118682) * 997d43618 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5c3 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e1a [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18c4 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a5d Fix path for require.js (flutter/flutter#118722) * c83a69855 update uikit view documentation (flutter/flutter#118715) * 2b3ca0dc4 Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc85 [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e4c Docs fix an=>a (flutter/flutter#118652) * 11d21e066 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab01 Appbar iconTheme override fix (flutter/flutter#118681) * 6f708305d Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2c0 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63ae8 Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212ca 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443a3 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d065f Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db4a 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec0c 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a10 [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0caf Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb3d Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909ccfa Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd14d 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab64049 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a5a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30a9 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef25 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c61 Support iOS wireless debugging (flutter/flutter#118104) * cbf2e1689 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590a8 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45bf Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f54d [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca50c Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff11d [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e65 Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f661 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd96 [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421)

`idevicesyslog` requires the `--network` flag to obtain logs for iOS devices when wirelessly paired. When running Flutter on devices with iOS 12 or earlier versions, [the `idevicesyslog` command is used.](https://github.com/flutter/flutter/blob/5931b4f21da0c564b28794f40257b5f660596a3e/packages/flutter_tools/lib/src/ios/devices.dart#L1269-L1277). Related Issue: #15072 Related PRs: #118104, #118895, #60623

setup wireless debugging to use device IP

8a607d3

flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 6, 2023

vashworth commented Jan 6, 2023

View reviewed changes

vashworth added 3 commits January 6, 2023 12:03

fix tests

2dfdf97

fix unused var and missing annotation

5f3caaa

remove unneeded try catch

5691519

This was referenced Jan 6, 2023

iOS network device not available when doing flutter run #118109

Closed

iOS network device not selected when running/debugging in VSCode #118113

Closed

vashworth marked this pull request as ready for review January 6, 2023 19:56

vashworth requested a review from jmagman January 6, 2023 20:01

vashworth commented Jan 6, 2023

View reviewed changes

vashworth added 2 commits January 6, 2023 14:19

remove commented out line, change null to package id

3e6c1a0

better way to get package id

b63c79c

jmagman reviewed Jan 6, 2023

View reviewed changes

update mDNS lookup to continously check for server, add messaging if …

180e93d

…takes too long to find observatory url, update flutter drive to enable publish-port if using network device

vashworth requested a review from jmagman January 9, 2023 21:46

jmagman reviewed Jan 9, 2023

View reviewed changes

vashworth requested a review from jmagman January 12, 2023 19:45

jmagman reviewed Jan 12, 2023

View reviewed changes

vashworth added 3 commits January 12, 2023 17:37

add and update comments, use logger spinner intead of timer in flutte…

60c487b

…r attach, other small improvements

add newline to message so next log won't be on same line

0cf0b70

fix install/waiting for permission status progress so it doens't doub…

f42e382

…le print the time it took.

jmagman requested a review from christopherfujino January 13, 2023 19:35

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

5cd2d4c Support iOS wireless debugging (flutter/flutter#118104)

6acbda6

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to ec6ff90ab0e6 (55 revisions) flutter/plugins#6999

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

5cd2d4c Support iOS wireless debugging (flutter/flutter#118104)

356dffd

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to 492d57262faf (56 revisions) flutter/plugins#7000

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

5cd2d4c Support iOS wireless debugging (flutter/flutter#118104)

f72b55a

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to f291eb3495f2 (57 revisions) flutter/plugins#7001

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

5cd2d4c Support iOS wireless debugging (flutter/flutter#118104)

c670de4

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to ab3c82244e27 (58 revisions) flutter/plugins#7002

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

5cd2d4c Support iOS wireless debugging (flutter/flutter#118104)

9c83ef5

auto-submit bot pushed a commit that referenced this pull request Jan 20, 2023

[reland] Support wireless debugging (#118895)

a07e8a6

* Reland "Support iOS wireless debugging (#118104)" This reverts commit cbf2e16. * Remove device loading status

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to a07e8a6ac43d (60 revisions) flutter/plugins#7003

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

5cd2d4c Support iOS wireless debugging (flutter/flutter#118104)

d357d35

jmagman mentioned this pull request Jan 20, 2023

With the --machine flag Logger.startProgress did not emit valid json #118907

Open

jmagman mentioned this pull request Jan 20, 2023

flutter run should support wireless debugging of iOS devices #15072

Closed

vashworth mentioned this pull request Mar 30, 2023

Error when running flutter attach --ipv6 #123821

Closed

2 tasks

vashworth deleted the wireless_debugging_v2 branch September 27, 2023 15:35

jaeyoi mentioned this pull request Jan 12, 2024

Support wireless debugging for iOS 12 or earlier #141439

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support iOS wireless debugging #118104

Support iOS wireless debugging #118104

vashworth commented Jan 6, 2023 •

edited

vashworth Jan 6, 2023

jmagman Jan 6, 2023

vashworth Jan 9, 2023

vashworth commented Jan 6, 2023 •

edited

vashworth Jan 6, 2023

jmagman commented Jan 6, 2023

jmagman Jan 6, 2023

vashworth Jan 9, 2023 •

edited

jmagman Jan 6, 2023

vashworth commented Jan 6, 2023 •

edited

jmagman commented Jan 6, 2023

vashworth commented Jan 6, 2023

jmagman left a comment

jmagman Jan 9, 2023

jmagman Jan 9, 2023 •

edited

vashworth Jan 9, 2023

jmagman Jan 10, 2023

vashworth Jan 12, 2023

jmagman Jan 12, 2023

vashworth Jan 12, 2023 •

edited

		_logger.printError('Port publication (publish-port) must be enabled for wireless debugging.');
		return LaunchResult.failed();

	_logger.printError('Port publication (publish-port) must be enabled for wireless debugging.');
	return LaunchResult.failed();
	throwToolExit('Cannot start app on wirelessly tethered iOS device. Try running again with the --publish-port flag');

Support iOS wireless debugging #118104

Support iOS wireless debugging #118104

Conversation

vashworth commented Jan 6, 2023 • edited

Steps to setup

Steps to test flutter run

Steps to test flutter attach (with app running in Xcode)

Steps to test with IPv6

Limitations

Things still need to be done

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vashworth commented Jan 6, 2023 • edited

Choose a reason for hiding this comment

jmagman commented Jan 6, 2023

Choose a reason for hiding this comment

vashworth Jan 9, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vashworth commented Jan 6, 2023 • edited

jmagman commented Jan 6, 2023

vashworth commented Jan 6, 2023

jmagman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmagman Jan 9, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vashworth Jan 12, 2023 • edited

Choose a reason for hiding this comment

vashworth commented Jan 6, 2023 •

edited

Steps to test `flutter run`

Steps to test `flutter attach` (with app running in Xcode)

vashworth commented Jan 6, 2023 •

edited

vashworth Jan 9, 2023 •

edited

vashworth commented Jan 6, 2023 •

edited

jmagman Jan 9, 2023 •

edited

vashworth Jan 12, 2023 •

edited