Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateRangePicker keyboardType #122353

Merged
merged 3 commits into from Mar 15, 2023
Merged

DateRangePicker keyboardType #122353

merged 3 commits into from Mar 15, 2023

Conversation

justinmc
Copy link
Contributor

Adds keyboardType parameter to DateRangePicker.

Fixes #121912.

@justinmc justinmc self-assigned this Mar 10, 2023
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 10, 2023
@justinmc justinmc marked this pull request as ready for review March 10, 2023 18:14
Renzo-Olivares
Renzo-Olivares approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I wonder if we want to limit the set of TextInputType that DateRangePicker supports. Is there any TextInputType that doesn't make sense in the context of DateRangePicker?

@justinmc
Copy link
Contributor Author

@Renzo-Olivares Good point, it would be weird to use the emailAddress keyboard type in a date picker... The original DatePicker class doesn't limit it though. I can't say we should necessarily stop someone if they explicitly set it to something weird. I wouldn't be surprised if there are some edge cases where setting the keyboard to a non-date-related keyboard type makes sense.

If you have a specific idea let me know though.

@justinmc
Copy link
Contributor Author

justinmc commented Mar 15, 2023 •
edited

Google testing appears stuck for the last several days, but it shouldn't be a problem. Merging.

@justinmc justinmc merged commit ffed0d5 into flutter:master Mar 15, 2023
34 of 35 checks passed
@justinmc justinmc deleted the date-range-picker-keyboard branch March 15, 2023 18:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
ffed0d57e DateRangePicker keyboardType (flutter/flutter#122353)
bb0d4bc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
ffed0d57e DateRangePicker keyboardType (flutter/flutter#122353)
47c523e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
ffed0d57e DateRangePicker keyboardType (flutter/flutter#122353)
236abd0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
ffed0d57e DateRangePicker keyboardType (flutter/flutter#122353)
28353fa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2023
@engine-flutter-autoroll
ffed0d57e DateRangePicker keyboardType (flutter/flutter#122353)
30db7d0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
ffed0d57e DateRangePicker keyboardType (flutter/flutter#122353)
1406e1c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
ffed0d57e DateRangePicker keyboardType (flutter/flutter#122353)
d1f9f0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

@justinmc justinmc

Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow changing of the keyboard type in DateRangePicker (similar to DatePicker)
3 participants
@justinmc @Renzo-Olivares @LongCatIsLooong